Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: profile component #282

Merged
merged 8 commits into from
Feb 13, 2025
Merged

feat: profile component #282

merged 8 commits into from
Feb 13, 2025

Conversation

dcbwe
Copy link
Contributor

@dcbwe dcbwe commented Feb 5, 2025

profile.blade.php skapad i resources/views/components/

Copy link
Contributor

@ell-ska ell-ska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes are needed! would be nice to see a screenshot or video of how this looks also :)

resources/views/profile.blade.php Outdated Show resolved Hide resolved
resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
Copy link
Contributor

@ell-ska ell-ska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, would love to see a preview of what this looks like and especially how it behaves responsively

resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
@endisset
</div>

<div class="flex grow flex-col gap-3 pr-10 text-slate-50">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is pr-10 needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

följer figmas design, kan tas bort

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finns ingen padding på denna div i figma?

resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
resources/views/components/profile.blade.php Show resolved Hide resolved
resources/views/profile.blade.php Outdated Show resolved Hide resolved
@ell-ska
Copy link
Contributor

ell-ska commented Feb 10, 2025

@dcbwe hur går det med denna? Något som är oklart?

@ell-ska ell-ska temporarily deployed to profile_component - u04-imdb-clone PR #282 February 11, 2025 08:44 — with Render Destroyed
@dcbwe
Copy link
Contributor Author

dcbwe commented Feb 11, 2025

screenshot_1 (5)
screenshot_1 (4)

@dcbwe dcbwe requested a review from ell-ska February 11, 2025 08:46
Copy link
Contributor

@ell-ska ell-ska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bra jobbat!

resources/views/components/profile.blade.php Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

den här filen finns det nu innehåll i i main. jag vet inte varför du inte får en merge konflikt men se till att du inte tar bort det som ligger i main innan denna mergas

@DavidDyberg DavidDyberg temporarily deployed to profile_component - u04-imdb-klon-grupp2 PR #282 February 13, 2025 09:58 — with Render Destroyed
@ell-ska
Copy link
Contributor

ell-ska commented Feb 13, 2025

we need this so i rebased it

@ell-ska ell-ska merged commit af0778b into main Feb 13, 2025
1 check passed
@ell-ska ell-ska deleted the profile_component branch February 13, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create profile component
4 participants